freezegun icon indicating copy to clipboard operation
freezegun copied to clipboard

Fix typo in setup.cfg: matadata → metadata

Open jdufresne opened this issue 4 years ago • 2 comments

Fixing to the typo exposed an issue building the wheel when using setup.py on a system without dateutil installed. To avoid the issue, move to a fully PEP517 compliant build approach.

jdufresne avatar Aug 25 '21 18:08 jdufresne

The change to read the version is something I disagree with. I've had to hunt down big performance issues on startup for some projects that were partly due to people doing that.

The title of this PR also doesn't reflect the change.

boxed avatar Aug 25 '21 18:08 boxed

The change to read the version is something I disagree with. I've had to hunt down big performance issues on startup for some projects that were partly due to people doing that.

No problem it has been reverted.

It was done originally to handle system without dateutil installed at build time (such as GH actions) but this is now better resolved using a fully PEP517 configuration. Thanks for the nudge in this direction!

jdufresne avatar Aug 25 '21 18:08 jdufresne