practical-pytorch icon indicating copy to clipboard operation
practical-pytorch copied to clipboard

added support for arbitrary encoding/unicode

Open cgadgil opened this issue 8 years ago • 2 comments

Added support to process "arbitrary" encoding in text. Parametrized the char set rather than depend on hard coded ascii.

cgadgil avatar Jul 16 '17 03:07 cgadgil

Looks good, thank you. If you could clean up some of the commented out lines I'll merge it in.

By the way this would be great to have in https://github.com/spro/char-rnn.pytorch

spro avatar Jul 22 '17 18:07 spro

Sure. I have cleaned up a bit more and added some params. Will submit new request after testing a bit more.

On Sat, Jul 22, 2017 at 11:50 AM, Sean Robertson [email protected] wrote:

Looks good, thank you. If you could clean up some of the commented out lines I'll merge it in.

By the way this would be great to have in https://github.com/spro/char- rnn.pytorch

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spro/practical-pytorch/pull/44#issuecomment-317202902, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOXzo297N4oAFZjqGWZRNeFwJ3o6G1Qks5sQkSCgaJpZM4OZMCm .

cgadgil avatar Jul 22 '17 20:07 cgadgil