char-rnn.pytorch icon indicating copy to clipboard operation
char-rnn.pytorch copied to clipboard

The epoch argument is wrong

Open wlnirvana opened this issue 7 years ago • 1 comments

The --n_epochs argument is in fact an iteration, which updates the weight based on a random sample of data points.

There is no conclusive definition, but the community generally define epoch to be an entire pass of the whole dataset. See this and this

wlnirvana avatar Jan 08 '18 08:01 wlnirvana

Yes, the code is counting the number of iterations, not number of epochs

samlanka avatar Jan 23 '18 03:01 samlanka