madewithwagtail icon indicating copy to clipboard operation
madewithwagtail copied to clipboard

Published 20 hours ago • verified publisher icon springload

Twitter api

Open jennyadamsnz opened this issue 7 years ago • 5 comments

A few things that should/could be done that I'm not 100% sure how to do and would appreciate suggestions on:

  • storing keys and tokens in a local.py? Is this needed?
  • making the url in the tweet a clickable link - nice to have
  • then auto-shortening the url
  • setting up a character limit so that if the character limit is over 140 that the "Welcome" part of the string is dropped to give extra characters - probably good to have in case of a long website nice which will mean a long url...

jennyadamsnz avatar Oct 13 '17 01:10 jennyadamsnz

I've run a test on my local to the new MWW Twitter profile (currently private) which is here and shows a test run of the current code: https://twitter.com/MadeWithWagtail (login is on lastpass)

jennyadamsnz avatar Oct 13 '17 01:10 jennyadamsnz

As agreed last week I'll have a look at this PR later this week, however as @ryami333 pointed, this repo is public, therefore anybody can read the credentials.

Things to do now:

  • Remove the twitter_credentials.py file.
  • Add the required keys to local.py.example so people know that those keys are expected.
  • Rebase the branch to remove any trace of the twitter_credentials.py file. It should appear that this file never existed.
  • Force push the rebase branch to the remote
  • Log into Twitter and make the current credentials invalid.

On deployment, we will need to make sure to update local.py with the required keys.

loicteixeira avatar Oct 16 '17 00:10 loicteixeira

Cool, thanks everyone. Will do today. Fortunately I made the twitter ac private ;) whew!

jennyadamsnz avatar Oct 17 '17 20:10 jennyadamsnz

Thanks @loicteixeira for your reviews and @ryami333 for your help. Unfortunately I've now run out of time to do the final unit testing needed to finish this little project off. @thibaudcolas or @haydnnewport is that something I can leave with one of you please? I would love to see it finally finished!

jennyadamsnz avatar Oct 26 '17 09:10 jennyadamsnz

Nice work @jennyadamsnz.

It's sad to see you leave but this project is public so you're more than welcome to continue the work on it if you want to complete it yourself (although you might need to either fork and create a new PR or ask infrastructure to give you write rights to this repo).

Otherwise don't worry, we will wrap it up and merge it :)

loicteixeira avatar Oct 26 '17 21:10 loicteixeira