springfox-grails-integration icon indicating copy to clipboard operation
springfox-grails-integration copied to clipboard

Published 20 hours ago • verified publisher icon springfox

Working on Grails 3.3.9

Open abcfy2 opened this issue 6 years ago • 2 comments

Thanks to @igoraguiar from #31 . Just fix CI failure.

TODO: Fix deprecated GrailsDomainClass.

abcfy2 avatar Mar 19 '19 07:03 abcfy2

Hi. Will this pull request be merged into master?

gabivis avatar Sep 30 '19 08:09 gabivis

I spent some time testing this fork in a project with grails 3.3.9.

Summary:

  • Configuration / startup of springfox works (springfox + swagger + swagger UI + springfox grails)
  • Swagger endpoints are generated for domain classes and declared REST endpoints (UrlMappings)
  • Swagger UI is generated correctly (correct fields shown) and creates valid requests

Some caveats from my review:

  • I don't use CRUD methods for my project, so I can't say 100% that everything works as expected for domain classes.
  • The deprecation of GrailsDomainClass could cause issues, however I don't have enough knowledge about Grails 2 vs 3 to evaluate the importance of the deprecation.

thilo-behnke avatar Jul 24 '20 22:07 thilo-behnke