batpred
batpred copied to clipboard
springfall2008
Templated UI
CURRENTLY DRAFT, DO NOT MERGE
This PR moves all the HTML templates, plus the simpler HTML page content generation, out into HTML template files. These files are then filled out by Jinja2 (a templating library).
web.py will ultimately just be responsible for gathering the data that's needed for each web page, and passing that data to the templating engine so it can build out the HTML that's required for each page.
However, for now, some pages still have logic in web.py which generates HTML, but now this is just for filling the content block in the middle of each template. Over time, these will transition out.
@springfall2008 I created a PR to make it easier to see the differences, and also to make discussing it easier - it was really hard to see the comments you'd made on the commit, there was no way to simply show all comments.
Also, you flagged a couple of lines as having merge issues, I couldn't see any changes to them in the PR when I created it. Let me know in this PR if you think there's still an issue.
Can you tag me in any comments please so I get notified, otherwise they're a bit hard to spot in the midst of everything else?
I don't spot any obvious errors apart from the one comment I made about the file list
I may return to this at some point but the implementation moved on a lot and it was hard to merge