boomcatch icon indicating copy to clipboard operation
boomcatch copied to clipboard

fix rt query parameter and rt new data format

Open itsMattShull opened this issue 6 years ago • 2 comments

To fix https://github.com/springernature/boomcatch/issues/49 and https://github.com/springernature/boomcatch/issues/83

itsMattShull avatar Jul 04 '18 22:07 itsMattShull

@josebolos it appears Travis failed because no Node environment was set. Is this something I can fix on my end?

itsMattShull avatar Jul 10 '18 02:07 itsMattShull

Hi @derekshull

Thanks for contributing to boomcatch, this is great!

The reason the tests in Travis are failing is because the changes in this PR break some of the unit tests. You can see the details of the test run here: https://travis-ci.org/springernature/boomcatch/jobs/400192639

Your PR tries to address two different problems - we usually ask people to submit different PRs for different issues, as it makes it easier to revert changes in case something goes wrong.

Do you have the time and energy for submitting separate PRs with their respective unit tests? It will be greatly appreciated.

Thanks again!

josebolos avatar Jul 12 '18 14:07 josebolos