springdoc-openapi-maven-plugin icon indicating copy to clipboard operation
springdoc-openapi-maven-plugin copied to clipboard

add new parameter `failOnError`, which can be set to fail builds

Open timbuethe opened this issue 1 year ago • 9 comments

This adds a new parameter called failOnError which should makes builds fail, instead of just logging an error, if the file download fails (return code != 200).

timbuethe avatar Jun 03 '23 10:06 timbuethe

Hi, is there any chance this gets reviewed and hopefully merged? Is there anything else you need from my side to move forward?

cc: @DennisHalmstad @bnasslahsen

timbuethe avatar Jul 04 '23 12:07 timbuethe

@bnasslahsen possible to review this MR? Its a very useful feature to have.

amitojduggal avatar Jun 14 '24 13:06 amitojduggal

@timbuethe,

I will have a look in the week-end!

bnasslahsen avatar Jun 14 '24 13:06 bnasslahsen

Hi @timbuethe,

i am also interested in your solution for #59. Can u add your handler at the catch-Block of exceptions too? It will help in situations like connection refused.

MrSebastian avatar Jul 11 '24 16:07 MrSebastian

I noticed that my application, that i started in pre-integration-test phase, did not stopped after the exception. I suggest to check, that the output exists, in the verify phase.

MrSebastian avatar Jul 11 '24 17:07 MrSebastian

@MrSebastian I also added it to the catch clause, let men know what you think.

timbuethe avatar Jul 15 '24 14:07 timbuethe

@timbuethe thx, yes that would work and throw an exception when requested service is unreachable.

But as mentioned in my comment before, it would be useful to have a separate verify goal. But i guess this is something the maintainer should decide. I hope it is ok to discuss things like that in this PR (this is my first foreign github project I participate with).

MrSebastian avatar Jul 17 '24 20:07 MrSebastian

@MrSebastian I agree, but let's see what @bnasslahsen has to say.

timbuethe avatar Jul 18 '24 11:07 timbuethe

It would also be nice to know why it failed to generate the file. The 401 does not tell me anything actionable.

S2Philipp avatar Aug 05 '24 14:08 S2Philipp