spring-social-google icon indicating copy to clipboard operation
spring-social-google copied to clipboard

Move spring-social-google into spring-projects

Open jiwhiz opened this issue 9 years ago • 7 comments

Hi @GabiAxel

I sent a spring-boot PR (https://github.com/spring-projects/spring-boot/pull/2548) to add spring boot starter for spring social google. But since spring-social-google is not spring projects, they put it on-hold.

Since spring social already has Twitter, Facebook, LinkedIn, I suggest to move spring-social-google into spring-projects. And this project will have better support from spring team. It will be very trivial code changes, since the code base follows the exact same pattern of other spring social projects.

What do you think?

Thanks.

jiwhiz avatar Apr 11 '15 17:04 jiwhiz

Greetings @jiwhiz ,

Makes sense to me, but it's not really my decision.

@habuma - what do you say?

GabiAxel avatar Apr 11 '15 17:04 GabiAxel

Thank you @GabiAxel :)

jiwhiz avatar Apr 12 '15 04:04 jiwhiz

Be interesting to see this moved over, for sure.

mlaccetti avatar Apr 12 '15 17:04 mlaccetti

Please note that I wasn't suggesting that moving this project to the spring-projects organisation was necessarily the right thing to do. The other option is to update the group id so that it isn't in the org.springframework namespace. This would make it clear that this is a third-party Spring Social module rather than one that's developed and supported by the Spring team.

wilkinsona avatar Apr 14 '15 08:04 wilkinsona

@GabiAxel Hi! I've been talking to @dsyer about moving this into spring-projects The problem is finding people to maintain the repo. So my suggestion would be that there could be a couple of us to maintain it.

I've got a pull request ready for adding spring boot auto configuration. And I could do the initial move if they setup a new repo for us.

What do you say?

leon avatar Oct 14 '15 06:10 leon

Before moving it over, I'd like us to hook into Travis and Coveralls, just to get the quality assurance taken care of. After that, I don't see it being a problem.

mlaccetti avatar Oct 14 '15 14:10 mlaccetti

Are there many people currently maintaining this? I would like to join as a contributor.

patons02 avatar Dec 09 '16 23:12 patons02