sts4 icon indicating copy to clipboard operation
sts4 copied to clipboard

Add support for injection Annotations

Open gayanper opened this issue 5 years ago • 5 comments

Change-Id: I6e35104c9d254a818aa22c1ee679d43c2456d4a2 Signed-off-by: gayanper [email protected]

gayanper avatar Feb 09 '19 14:02 gayanper

PR which adds support for mostly used injection annotations.

gayanper avatar Feb 09 '19 14:02 gayanper

Great that you found the time to work on this, much appreciated. Before we can merge the PR, I would need to have a bunch of automated tests for this new symbol provider, as we have for the other symbol providers. That usually involves creating a test project with some sample sources included and writing the unit tests for that, maybe similar to the SpringIndexerBeansTest (but there are others, too).

martinlippert avatar Feb 09 '19 20:02 martinlippert

Sure i will work on it. What do you think about the @= prefix?

gayanper avatar Feb 11 '19 12:02 gayanper

The prefix in general sounds fine to me, but I always need to play around with early prototypes and see the things in action to really be able to make up my mind about them. But changing that prefix in the future (if necessary) is not a big deal, maybe you should extract that into a constant to make it even easier.

martinlippert avatar Feb 12 '19 10:02 martinlippert

Nice Work Dude

abha68738 avatar Sep 12 '23 14:09 abha68738