spring-ws icon indicating copy to clipboard operation
spring-ws copied to clipboard

Support WSS4J subject cert constraints

Open runeflobakk opened this issue 5 years ago • 4 comments

If no Subject DN Certificate Constraint has been configured for the case described here http://koenserneels.blogspot.com/2013/09/ws-security-using-binarysecuritytoken.html WSS4J emits the following warning:

WARN - org.apache.wss4j.common.crypto.CryptoBase - No Subject DN Certificate Constraints were defined. This could be a security issue

CryptoBase.java

This PR is a work-in-progress for adding support for configuring Subject DN Certificate Constraint for WSS4J (SIG_SUBJECT_CERT_CONSTRAINTS ).

More info in JIRA-issue: https://jira.spring.io/browse/SWS-1058

runeflobakk avatar Mar 11 '19 20:03 runeflobakk

@runeflobakk Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster avatar Mar 11 '19 20:03 pivotal-issuemaster

@runeflobakk Thank you for signing the Contributor License Agreement!

pivotal-issuemaster avatar Mar 11 '19 20:03 pivotal-issuemaster

Is it something I can do to enable some progress on this pull request? Thank you.

runeflobakk avatar Feb 09 '20 16:02 runeflobakk

Not affiliated with Spring but it looks like you could add test cases. In particual there should be one test to verify that changes do not change defaults when option is not set by user, and then a test to verify behavior when set. FYI:ws-proxy is a real asset, thanks ! FYI: wss4j 2.4.0 adds MS compatability for IssuerSerial DN

free-ice avatar Nov 24 '21 04:11 free-ice