spring-projects
Introduce observability support [SWS-1024]
Would it be of use to add support for Micrometer Observations for WebServiceTemplate and perhaps also for server Endpoints? Seems like this would require to add a dependency to Micrometer Observation and possibly request som modifications in the Spring Boot project? From the Observation api it's possible to add support for Micrometer Metrics, and possibly also Tracing (but I haven't looked into Tracing details).
When are you planning to release this feature? This was marked as 4.1.x and is now part of a general backlog :/
When time permits, I am afraid and the current milestone reflects that.
A PR that's consistent with what we're doing elsewhere would go a long way to make progress. I did review the current hook points and the metrics that we could expose and it's far from obvious how we could get those with the current API.
When I started working on this PR I got feedback from users that seemed to have good knowledge in how this should be structured. Maybe I could try to do some more work where it is needed, but that would require som guidance in what's missing as of current state. Change metrics names? Restructure code? I can imagine that focus currently is delivering SpringBoot4, but feedback is welcome when there is time to spare!
@johkin Don't worry, Stéphane and I have good knowledge of instrumenting Spring projects, we are both involved in Spring Boot auto-configurations and worked on the Spring Framework instrumentations (HTTP, JMS, @Scheduled).
In this case, we reviewed the existing work and found several issues:
- we were not sure about the semantics (observation names, contextual names and keyvalues)
- the instrumentation was incomplete as it was not opening an observation scope (so this would not appear as a span in traces)
It's all fixable, but while looking into this we also found that spring-ws was indeed not providing the right extension points for instrumentation in some cases, and that we might consider direct instrumentation (as in internal) for others. This required more changes in the codebase and we ran out of time for this generation. We will let you know when we resume work on this. Thanks for your patience.
