spring-webflow
spring-webflow copied to clipboard
spring-projects
Want to set expiration exclude conversation flow to ConversationContainer. [SWF-242]
Daigo Kobayashi opened SWF-242 and commented
Since SWF 1.0.1, default maxConversations become 5. But in some case, I want to set expiration exclude flow to ConversationContainer. Because if I use frame, menu always displayed but conversation id is expired. So I can't recover menu's state.
Following url is relevant forum's post. http://forum.springframework.org/showthread.php?t=33597
Affects: 1.0.1
Attachments:
- ConversationContainer.java.patch (3.52 kB)
- ConversationContainer.java.patch (3.44 kB)
- ExecutorBeanDefinitionParser.java.patch (3.95 kB)
- FlowExecutorFactoryBean.java.patch (2.95 kB)
- FlowExecutorFactoryBean.java.pathc (2.36 kB)
- SessionBindingConversationManager.java.patch (2.16 kB)
- SessionBindingConversationManager.java.patch (2.15 kB)
- spring-webflow-config-1.0.xsd.patch (773 bytes)
Issue Links:
- #184 Support for maxConversations / maxContinuations on a flow-by-flow basis
Daigo Kobayashi commented
I've created patch for this improvement.
note: http://opensource.atlassian.com/projects/spring/browse/SWF-239 This issue is related to this problem. Because ExecutorBeanDefinitionParser doen't work on SWF 1.0.1. So this patch also include #1138's patch.(I just check trunk code and copy it.)
Daigo Kobayashi commented
I'm really sorry. But my previous patch has problem. So I update patch. Please discard previous FlowExecutorFactoryBean, ConversationContainer and SessionBindingConversationManager patches.
Jon Osborn commented
Interesting fix. Why didn't you use session scoping for the menu items? That is what you are trying to achieve by this fix.
Daigo Kobayashi commented
Thank you for reviewing my code.
As I mentioned SWF's formu(http://forum.springsource.org/showthread.php?t=33597), menu has its own flow. So I didn't use session scope and this patch was necessary to prevent expiration of menu flow.