spring-vault icon indicating copy to clipboard operation
spring-vault copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Leases no longer revoked after stopping SecretLeaseContainer

Open NoureddineDahmen opened this issue 1 year ago • 2 comments

I reopen this issue related to https://github.com/spring-projects/spring-vault/issues/844 We tested the version 3.1.1 and and unfortunately we still have the issue.

Best regards,

NoureddineDahmen avatar Jan 31 '24 13:01 NoureddineDahmen

Can you check your shutdown debug logs regarding Vault communication and debug what happens for you in SecretLeaseContainer.destroy() as there is the code path to revoke secrets?

mp911de avatar Jan 31 '24 14:01 mp911de

Hello @mp911de , I'm sorry for the delay to give feedback . In Debug , the method SecretLeaseContainer.destroy() is not called when we use ConfigData and it well called when we use Boostrap Config.

Best Regards,

NoureddineDahmen avatar Mar 20 '24 14:03 NoureddineDahmen

This needs to be handled in Spring Cloud Vault as part of the bean registration, see https://github.com/spring-cloud/spring-cloud-vault/issues/725

mp911de avatar Apr 08 '24 07:04 mp911de