spring-vault icon indicating copy to clipboard operation
spring-vault copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

ReactiveVaultTemplate for the key-value backend version 2

Open amrynsky opened this issue 3 years ago • 2 comments

It would be great if ReactiveVaultTemplate supports KV backend v2 similar to non-reactive version.

As a workaround, it's possible to use the current client and just add data to the path and wrap all POJO into data element but having built-in support would simplify v1->v2 migration.

amrynsky avatar Aug 24 '20 20:08 amrynsky

Feel free to submit a pull request. We initially didn't provide any higher-level API as we waited for signals how/whether the reactive API will be used.

mp911de avatar Aug 31 '20 12:08 mp911de

Any plan on this issue?

cantaylancapraz avatar Jun 02 '22 21:06 cantaylancapraz

Working on a PR for the reactive versioned/unversioned key-value operations (I can potentially work on the other operations classes after I am done with this). Seems pretty straight forward.

I am starting to collect some questions. Is this enhancement the right place to ask questions until I get a PR created?

tweiand avatar Mar 24 '23 15:03 tweiand

Great news, @tweiand. This is the right place to discuss design and questions.

mp911de avatar Mar 27 '23 06:03 mp911de

Started putting code in the enhancement-576 branch of my fork. Unit tests are created and working for V1. Have not been able to look into this for a few weeks, but, hopefully will have more time now.

Here is my current plan:

  • Port the imperative code to be reactive
  • Fix my current initialization of ObjectiveMapper in ReactiveVaultKeyValueAccessor
  • Cleanup of code & work on JavaDocs and attribution

tweiand avatar Apr 17 '23 19:04 tweiand

Thanks for the update. Please note that we've upgraded Spring Javaformat which might require a rebase on your side to avoid merge conflicts caused by an updated code format.

mp911de avatar Apr 19 '23 09:04 mp911de

Update on this: I have integration tests for the new code and they are all passing. All JSON parsing done with WebClient, no extra ObjectMapper needed. I am not ready for a review yet, but, I am good with people starting to look at the code with the assumption that things will be changing.

Left to do before requesting review:

  • Ensure code coverage & static analysis (both unit and integration tests)
  • Reduce/Remove duplicate code
  • Finish reviewing changes for new APIs
  • Update all JavaDocs
  • Rebase for Spring Javaformat

General comments so far about the repo:

  • Thank you for making new tests easy!
  • Some fun gems in here for dynamically creating generic Types

tweiand avatar May 03 '23 03:05 tweiand

I plan on having a MR ready for review at the end of the week.

tweiand avatar May 13 '23 18:05 tweiand

Finding time to complete this. Had other priorities pop up😀

tweiand avatar May 25 '23 21:05 tweiand

Still working on this, but, away from my laptop for two weeks.

tweiand avatar Jun 10 '23 15:06 tweiand

May I please get initial feedback on #807? It still needs work on the java docs and maybe some code deduplication. Wanted to get the conversation started.

tweiand avatar Jul 20 '23 00:07 tweiand

Hey all! Can I please get an initial review of #807 please? Once I have the initial feedback I can finish this up.

tweiand avatar Aug 03 '23 18:08 tweiand

I've been on vacation for the past weeks and I'll have a look in the next days.

mp911de avatar Aug 10 '23 07:08 mp911de