spring-statemachine icon indicating copy to clipboard operation
spring-statemachine copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Kryo generates warning in JDK-11

Open dturanski opened this issue 4 years ago • 4 comments

see https://github.com/spring-cloud/spring-cloud-skipper/issues/971

dturanski avatar Aug 19 '20 16:08 dturanski

Not really sure what we should do all these warnings. We get some with a gradle build stuff and there's warning from eclipse uml libs as well.

jvalkeal avatar Sep 06 '20 15:09 jvalkeal

There's a system property to set for Kryo to ignore the warnings, but I'm not sure which component would do that. We get similar warnings from Spring reflection as well. So...

From: Janne Valkealahti [email protected] Sent: Sunday, September 6, 2020 11:11 AM To: spring-projects/spring-statemachine [email protected] Cc: David Turanski [email protected]; Author [email protected] Subject: Re: [spring-projects/spring-statemachine] Kryo generates warning in JDK-11 (#862)

Not really sure what we should do all these warnings. We get some with a gradle build stuff and there's warning from eclipse uml libs as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fspring-projects%2Fspring-statemachine%2Fissues%2F862%23issuecomment-687815476&data=02%7C01%7Cdturanski%40vmware.com%7C4443c77661be4da82a3208d8527723c1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637350018937705094&sdata=WJghkEzf4Y74qFH0Rjkp86iH%2Fl7FcZysnl9kGCdO0H8%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAGYQS6AP3W5D55YJZENI23SEORCJANCNFSM4QFE2GOA&data=02%7C01%7Cdturanski%40vmware.com%7C4443c77661be4da82a3208d8527723c1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637350018937715088&sdata=86Oj7ihELtZpQKcwL05P%2ByVKJyPjkC86Bj%2B0Ik%2BLOaA%3D&reserved=0.

dturanski avatar Sep 08 '20 13:09 dturanski

Yeah, we're not going to a business of setting or forcing system props. Hopefully there's some fix in kryo at some point.

jvalkeal avatar Dec 15 '20 22:12 jvalkeal

I believe that SSM would be greatly benefited from upgrading kryo to version 5.x @jvalkeal. Dealing with mutable objects in the extended state is not ideal. Are there any plans for it? Here is what they're saying at kryos project

Daanielvb avatar Aug 18 '21 12:08 Daanielvb