spring-session icon indicating copy to clipboard operation
spring-session copied to clipboard

Consider making Session implementations public

Open marcusdacoregio opened this issue 2 years ago • 1 comments

Expected Behavior

It should be possible to extend or delegate to those implementations.

Current Behavior

  • SessionRepository implementations are open for extension but cannot be extended, e.g. there is no way to override createSession or save methods.
  • This issue mentions that the MongoSession is an internal implementation detail of the MongoIndexedSessionRepository implementation. That actually is not 100% true since MongoSession is returned by the API.
  • The AbstractMongoSessionConverter is meant to be extended accordingly to its javadoc, but it is not possible since its abstract methods work with MongoSession and that implementation is package-private
  • Since each implementation is part of the public API, it is strange that they are not public

Context

  • https://github.com/spring-projects/spring-session/issues/2217
  • https://github.com/spring-projects/spring-session/issues/2179

marcusdacoregio avatar Mar 15 '23 19:03 marcusdacoregio

#2217 mentions this enhancement would be in 3.3 scheduled for this May, are we still on track to hit this goal?

Survival1sm avatar May 14 '24 19:05 Survival1sm