spring-security icon indicating copy to clipboard operation
spring-security copied to clipboard

Consider removing generics from `AuthorizationRequestRepository`

Open sjohnr opened this issue 1 year ago • 2 comments

See issue gh-15354.

sjohnr avatar Jul 15 '24 16:07 sjohnr

Did the discussion end with the direction of the issue removing unnecessary generics from the 'AuthorizationRequestRepository'?

I also want to prevent the existence of codes that don't fit logically, so the direction has been set, and I would like to open PR if possible.

HyoJongPark avatar Jul 16 '24 02:07 HyoJongPark

@HyoJongPark

Did the discussion end with the direction of the issue removing unnecessary generics from the 'AuthorizationRequestRepository'?

Yes, that is where we have landed for now.

I also want to prevent the existence of codes that don't fit logically, so the direction has been set, and I would like to open PR if possible.

That's great! However, this won't be worked on until work for Spring Security 7 begins, which is a ways out. Since we don't have a place to put code ahead of beginning development for that release, I want to avoid having a PR sit around for an extended period of time so I don't think we should open a PR at this time.

sjohnr avatar Jul 17 '24 16:07 sjohnr

Closing in favour of gh-18049

jgrandja avatar Oct 14 '25 20:10 jgrandja