spring-security icon indicating copy to clipboard operation
spring-security copied to clipboard
verified publisher icon spring-projects

Send saml logout response even when validation errors happen

Open 1livv opened this issue 1 year ago • 1 comments

solves https://github.com/spring-projects/spring-security/issues/14635

1livv avatar Mar 03 '24 20:03 1livv

Thanks for the PR, @1livv. This is going to take a little bit more work to maintain backward compatibility and also ensure that the APIs progress naturally. I'll get back to you soon with recommendations.

jzheaux avatar Mar 06 '24 22:03 jzheaux

Hi, @1livv, are you able to make the requested changes?

jzheaux avatar Apr 19 '24 15:04 jzheaux

Hey @jzheaux this slipped off my radar, i'll take a look in the next days. Sorry for the delay

1livv avatar Apr 19 '24 15:04 1livv

@1livv I'd be willing to take care of the change requests if you are ok with this

jan-knoblich avatar Aug 19 '24 13:08 jan-knoblich

Yes, that would be great thank you @jan-knoblich !!

1livv avatar Aug 19 '24 13:08 1livv

@1livv Could you Sync your repository with the main one? Otherwise I will have to create a new one. There are some changes that impact the changes in this PR This explains how to sync: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

jan-knoblich avatar Aug 27 '24 18:08 jan-knoblich

@1livv and @jan-knoblich, I've rebased the PR, thanks for your patience.

Would either of you like to apply the listed changes? If I don't hear from you one way or the other by next week, I'll go ahead and provide a polish commit myself.

jzheaux avatar Jun 05 '25 22:06 jzheaux

Thanks, @1livv! This is now merged into main. I also added fc7e6bced09827233a409148a5f9adc7fb5ec198 to update related documentation.

jzheaux avatar Jun 09 '25 22:06 jzheaux