spring-security icon indicating copy to clipboard operation
spring-security copied to clipboard

issue 3065 / SEC-2839 - fix

Open koosg opened this issue 3 years ago • 3 comments

Fix issue 3065 / SEC-2839: an old bug where it was possible to parse when the init did not succeed completely. Essentially, it was forgotten to refetch the parser after reloading the parsers.

koosg avatar Aug 18 '22 06:08 koosg

Hi, @koosg. Thanks for putting together this PR. There seems to be something wrong with it, though, as it suggests that you'd like to modify several hundred files and merge several hundred commits.

I think this is a change that is needed for all supported branches. Would you please try submitting your PR again, making the change on the 5.6.x branch? The PR should only contain your changes and have only one commit.

jzheaux avatar Aug 26 '22 18:08 jzheaux

Will do!

Op vr 26 aug. 2022 20:17 schreef Josh Cummings @.***>:

Hi, @koosg https://github.com/koosg. Thanks for putting together this PR. There seems to be something wrong with it, though, as it suggests that you'd like to modify several hundred files and merge several hundred commits.

I think this is a change that is needed for all supported branches. Would you please try submitting your PR again, making the change on the 5.6.x branch? The PR should only contain your changes and have only one commit.

— Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-security/pull/11720#issuecomment-1228786747, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADKLJLWCHKSEJMIJLBG5KTV3EC5NANCNFSM564AXOEQ . You are receiving this because you were mentioned.Message ID: @.***>

koosg avatar Aug 26 '22 19:08 koosg

changed target branch, should be the 5.8

koosg avatar Sep 05 '22 18:09 koosg

Thanks, @koosg! This is now merged into 5.6.x, 5.7.x, 5.8.x, and main

jzheaux avatar Nov 02 '22 00:11 jzheaux