spring-security icon indicating copy to clipboard operation
spring-security copied to clipboard

Fix IP address parse error message in IpAddressMatcher#parseAddress()

Open cyb3r4nt opened this issue 2 years ago • 2 comments

There is no whitespace between error message and IP address value IpAddressMatcher#parseAddress() If IP value is wrong, then error text looks like Failed to parse addressi.am.ip. There should be some separator between those two text tokens.

Also wrapped the address value with single quotes. Will this add any confusion for the caller? Or colon and "Failed to parse address: $value looks better?

cyb3r4nt avatar Aug 16 '22 14:08 cyb3r4nt

@cyb3r4nt Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Aug 16 '22 14:08 pivotal-cla

@cyb3r4nt Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Aug 16 '22 14:08 pivotal-cla

Thanks, @cyb3r4nt! This is now merged into main.

jzheaux avatar Aug 18 '22 16:08 jzheaux