spring-security-samples
spring-security-samples copied to clipboard
spring-projects
OAuth Sample Do not Test Actual Configuration
Summary
As it stands the tests that are in Spring Security's OAuth Samples do not test the actual configuration. They are instead copying and modifying the samples to allow testing.
This might seem innocent enough, but we don't want our users to follow this pattern. We need to demonstrate how the existing configuration can be used with perhaps mocking a small piece of the application or running a MockWebServer instance
@rwinch I'm not sure I understand the issue with the test(s). Can you please provide more detail.
OAuth2LoginApplicationTests currently uses SecurityTestConfig for the integration tests. We should remove SecurityTestConfig so that we're actually testing the WebSecurityConfigurerAdapter that the samples uses.
We also want the integration tests to follow the same pattern as in FormJcTests where pages are defined.
