spring-retry

spring-retry copied to clipboard

This PR fixes the issue explained here: [Issue number 427](https://github.com/spring-projects/spring-retry/issues/427). Please comment if there is any feedback.

aftabshk

@Retryable annotation retrying with ExponentialBackOff instead of ExponentialRandomBackOff when randomExpression provided

1

I am using following versions: Java - 17 Spring Retry - 2.0.5 Spring Boot - 3.2.5 Example code to reproduce issue: [spring-retry-issue](https://github.com/aftabshk/spring-retry-issue/tree/main) When I am using the @Retryable annotation like...

aftabshk

fix: Null pointer error may occur

2

@rmorgan @joshlong @javiereguiluz @trisberg

aozeyu

put GAV in docs

4

could you please put your group artifact version (or at least the first 2) in the docs somewhere? I find myself spending way too much time looking for them. https://docs.spring.io/spring-cloud-commons/docs/current/reference/html/#spring-cloud-circuit-breaker...

xenoterracide

This PR is an attempt to support a backoff policy based on the exception type thrown. It's similar to how we have a different retry policy based on the exception...

tony-clarke-amdocs

default implementation of @Backoff() should not use Thread.sleep

7

we used the @Retryable annotation in a project recently and added a backoff of like one day to our decently long running job , due to the implementation with Thread.sleep...

jonnytest1

Inconsistent validation of exponential backoff

3

[setMultiplier()](https://github.com/spring-projects/spring-retry/blob/main/src/main/java/org/springframework/retry/backoff/ExponentialBackOffPolicy.java#L140) in ExponentialBackoffPolicy allows a minimum multiplier of 1.0. However, the [corresponding builder method in RestTemplateBuilder](https://github.com/spring-projects/spring-retry/blob/main/src/main/java/org/springframework/retry/support/RetryTemplateBuilder.java#L202) insists on a minimum multiplier greater than 1.0. There's even a test for it....

aahlenst

RetrySynchronizationManager cause my context lost

1

RetrySynchronizationManager use ThreadLocal. when use @Async cooperate @Retryable Will cause the context data I set myself to be lost. Can open an interface for setting up the Theadlocal type

zyx13131133

Accepting java.time.Duration as alternative to milliseconds in arguments

9

It would be nice if all kinds of intervals and durations could be expressed as [java.time.Duration](https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/time/Duration.html) in addition to a `long` of milliseconds. It would make it easier to understand...

aahlenst

NullPointerException

2

why java.lang.NullPointerException: null at org.springframework.retry.annotation.AnnotationAwareRetryOperationsInterceptor.getDelegate(AnnotationAwareRetryOperationsInterceptor.java:161)? use spring-retry:1.2.5.RELEASE

lufei66666