spring-petclinic
spring-petclinic copied to clipboard
spring-projects
feat: Database configuration integration with Spring Boot
Simplified database configuration using the new Spring Boot Docker Compose feature.
You can use MySQL or PostgreSQL by simply defining the Spring Boot profile:
./mvnw spring-boot:run -Dspring-boot.run.profiles=mysql
or
./mvnw spring-boot:run -Dspring-boot.run.profiles=postgres
@jmformenti Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
You should also update the:/petclinic_db_setup_postgres.txt and/petclinic_db_setup_mysql.txt
accordingly :)
Removed that documentation because with these changes no manual steps are needed anymore.
Looking at it in more detail I'm not really sure I know what the intention was here. I don't want docker-compose to be the only option to run a database, and that seems to be the main idea behind the change? Was there something else I missed?
Looking at it in more detail I'm not really sure I know what the intention was here. I don't want docker-compose to be the only option to run a database, and that seems to be the main idea behind the change? Was there something else I missed?
Yes, the idea was essentially to simplify database configuration by leveraging the integration with docker compose, but I understand your point of view. I have modified the PR so that the integration with docker compose is optional. I hope this can be useful for those who want a quick way to start and/or integrate the application with a database.
Since we already support docker-compose for both mysql and postgres, this might end up being an empty pull request, once we whittle it down to what is actually needed. So far that looks like a few lines of documentation and some Maven profiles (but Gradle support is still missing, which we probably need if we are providing Maven examples). The details of what is in those profiles is still being debated, but I'm not convinced they are all that helpful. Maybe there is a problem with the documentation making it hard to understand the steps needed to run using docker compose? It could be that all we need is more clarity in the README?
Personally I like the idea to run the application and the database with a single command:
./mvnw spring-boot:run -P<database>
with any other docker or docker compose extra command but I guess that is not in the scope of this project, so feel free to close the PR.
I usually run from the IDE, so I'm not that bothered, but if that is the objective then it seems reasonable to me. Whatever we decide to do, it shouldn't take much code, IMO. We also haven't tried to cover the Gradle users yet, so there's a bit more work to do still.
Lastly, I'm not sure if we can do exactly the same for MySQL as Postgres since one of them (currently MySQL) is being used to showcase test containers and the other is showing docker compose. I would be happy if mvn spring-boot:test-run -Pmysql worked, but used test containers.
If you're not able to complete the PR that's OK. I'll leave it open for a bit to see if anyone else feels like doing it.