spring-petclinic icon indicating copy to clipboard operation
spring-petclinic copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Telephone number validation is not user friendly while adding owner

Open Jitendrajadhav1990 opened this issue 1 year ago • 2 comments

while adding owner, getting validation for Telephone is " numeric value out of bounds (<10 digits>.<0 digits> expected) must not be blank" which will can be user friendly like "Please enter a valid 10 digit mobile number Screenshot (1370)

Jitendrajadhav1990 avatar Sep 13 '23 05:09 Jitendrajadhav1990

That one should be trivial to fix. It's just a message isn't it? You could start with a PR for the default (English).

dsyer avatar Sep 19 '23 11:09 dsyer

Hey @dsyer , I've Added User Friendly Messages for blank fields. Please review this PR #1361 . I've also attached screenshots of before and after for better understanding of output of my commit.

Aayush-Kapur avatar Sep 26 '23 09:09 Aayush-Kapur

@Jitendrajadhav1990 It seems that the proposed solution to this issue, PR #1361 (merged by accident, now reverted), was superseded by #1483, which was merged three week ago.

Should this issue be closed?

codespearhead avatar Jun 08 '24 20:06 codespearhead