spring-integration icon indicating copy to clipboard operation
spring-integration copied to clipboard

Optimize AbstractCorrelatingMessageHandler Lock Keys [INT-2758]

Open spring-operator opened this issue 13 years ago • 2 comments

Gary Russell opened INT-2758 and commented

Currently, in order to accommodate the fact the JDBC Message Store uses a UUID representation of the group Id, the ACMH has to use the UUIDConverter to obtain the id of the lock for the group.

This is because the reaper only has the UUID, and not the original group key (correlation id).

When refactoring the JDBC message store to retain the original group key, ensure that the ACMH is also changed, to gain the optimization.


This issue is a sub-task of #6647

Issue Links:

  • #6650 Store the Plain Text Group Id instead or in addition to a UUID

spring-operator avatar Sep 19 '12 09:09 spring-operator

I wonder if that's still on the roadmap. Using the UUIDConverter all over the place is also bad for performance reasons: When not passing in a UUID, every time it internally throws an exception to detect invalid UUIDs. Creating stack traces is an expensive operation to do.

joshiste avatar Oct 14 '23 07:10 joshiste

@joshiste ,

we have done the fix for that UUIDConverter: https://github.com/spring-projects/spring-integration/commit/77d8dfd0916ec39bd0bbfec6608253ea226bb847.

The fix has nothing to do with this issue.

Thank you for the report!

artembilan avatar Oct 17 '23 18:10 artembilan