spring-integration-extensions icon indicating copy to clipboard operation
spring-integration-extensions copied to clipboard

Consider using another samba support library instead of jcifs

Open icstreispe opened this issue 2 years ago • 2 comments

We tried to use SI with the default library jcifs version 2.1.28 but the performance was very poor. We first thought might be a buffer size problem and tried to class shadow some internal spring and spring integration classes in order to boost performance but to no succes. Transferring a 200MB file took 13minutes+ no matter what. In the end we gave up using some SI components, build a custom component for file transfer to samba based on hierynomus/smbj library version 0.11.5 and our time transfer fall down to below 1m for 200MB.

icstreispe avatar Mar 28 '22 08:03 icstreispe

Sure! Having a new Spring 6 era I guess we are free to make radical changes in this Spring Integration SMB module as well. Feel free to contribute such a fix: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc. Kinda start version 2.0, based on Spring Integration 6.0 and so on.

Thanks

artembilan avatar Mar 28 '22 14:03 artembilan

I have been using this library for over 2 years in Production now and I have never experienced the performance issues that you mentioned... have you profiled that it is JCIFS causing the slowdown?

We could move this to another SMB library, however that would be a radical change I would imagine and we would need to make sure that all the functionality of JCIFS is reflected in SMBJ. Are you willing to take on this work?

GregBragg avatar Mar 28 '22 19:03 GregBragg