spring-framework icon indicating copy to clipboard operation
spring-framework copied to clipboard

Add `QUERY` HTTP method

Open desiderantes opened this issue 1 year ago • 4 comments

Fixes #32975

desiderantes avatar Aug 26 '24 14:08 desiderantes

Thanks for the initial efforts @desiderantes - at this point the linked issue hasn't been triaged and is very unlikely to make it to the 6.2 version. We'll need thorough reviews and testing for this one.

Note that since this is a new HTTP method and new feature, I don't think we will want to introduce it everywhere and for all variants of our web support. For example, I'm wondering if surfacing it as a first class citizen in RestTemplate is a good idea. Maybe using the exchange variants is good enough here?

bclozel avatar Aug 26 '24 14:08 bclozel

@bclozel Yes no worries, just wanted to get this started somehow. I do think that supporting a new HTTP Method shouldn't be half-hearted, and ideally it would mean support everywhere, not just in the basic HttpMethod class

desiderantes avatar Aug 26 '24 14:08 desiderantes

@desiderantes We're trying to balance maintenance and evolution, especially around parts that have been very stable for a long time. Adding this method as first class in WebClient and RestClient makes sense, but RestTemplate has been "feature complete" for a long time now and we don't want to expand its main surface API.

bclozel avatar Aug 26 '24 14:08 bclozel

Marking as blocked for now because https://github.com/spring-projects/spring-framework/issues/32975#issuecomment-2318415288

bclozel avatar Aug 30 '24 06:08 bclozel

rking as blocked for now becau

maybe then putting this PR into draft mode would help or communicate or even close as not planned. It can be reopened anytime

Pankraz76 avatar Mar 13 '25 14:03 Pankraz76

@desiderantes I think you closed this PR by accident. Care to reopen?

bclozel avatar Jun 03 '25 17:06 bclozel

@desiderantes I think you closed this PR by accident. Care to reopen?

Sorry, closed by mistake because I was refactoring and deleted the branch to move the commits to a separate branch, but forgot that I can't change the branch on a closed PR and can't reopen if the branches are the same.

desiderantes avatar Jun 03 '25 18:06 desiderantes