spring-framework icon indicating copy to clipboard operation
spring-framework copied to clipboard

Instrument RSocket Requester for Observability

Open riko-traveloka opened this issue 4 years ago • 6 comments

Hi team, until Spring Boot 2.4.0, there's no metrics auto-configuration for RSocketRequester. Would be nice if there's metrics auto-configuration so that we have visibility over the interaction (request-response, fire-forget, etc), both count and latency.

riko-traveloka avatar Dec 08 '20 12:12 riko-traveloka

I think this is a duplicate of spring-projects/spring-boot#16282.

mbhave avatar Dec 08 '20 18:12 mbhave

I'm not sure this is a duplicate. AIUI, spring-projects/spring-boot#16282 is about making the Actuator's endpoints available over RSocket and this issue is about RSocket-related metrics.

wilkinsona avatar Dec 09 '20 09:12 wilkinsona

Hi @mbhave, what @wilkinsona said is right. This issue is about enabling RSocketRequester metric and auto-configuration, and not about making actuator available over RSocket.

Currently RSocketRequester doesn't send any metrics (count and latency) CMIIW, and also there's no clean way to add metrics (no customizer).

Maybe just ignore the "actuator" part of this issue to remove confusion.

riko-traveloka avatar Dec 12 '20 00:12 riko-traveloka

Thanks for the clarification @riko-traveloka. I have reopened the issue.

mbhave avatar Dec 12 '20 01:12 mbhave

any progress?

zggg avatar Mar 05 '24 06:03 zggg

@zggg no progress so far as the demand is quite low. We will need to instrument the RSocket Requester directly in Spring Framework first before considering any auto-configuration in Spring Boot (this is why the issue has been transferred).

bclozel avatar Mar 05 '24 06:03 bclozel