spring-framework icon indicating copy to clipboard operation
spring-framework copied to clipboard

Support sending large STOMP messages as fragmented frames on `WebSocketStompClient`

Open injae-kim opened this issue 1 year ago • 2 comments

Closes gh-29354

Motivation

  • By https://github.com/spring-projects/spring-framework/issues/16152, we already added handling of fragmented STOMP frames receiving by BufferingStompDecoder like other stomp libraries (e.g. stomp-websocket.js)
  • But we not added handling of fragmented STOMP frames sending yet!
    • ref. stomp-websocket.js fragmented frames sending impl

Modification

  • Add SplittingStompEncoder to split large STOMP messages that exceeds outboundMessageSizeLimit

Result

  • Now user can send large STOMP messages as fragmented frames on WebSocketStompClient
  • Close https://github.com/spring-projects/spring-framework/issues/29354

injae-kim avatar Jan 07 '24 16:01 injae-kim

(Rebase to latest main branch to resolve conflict~!)

injae-kim avatar Jan 14 '24 12:01 injae-kim

Seems mentioned +1 on https://github.com/spring-projects/spring-framework/issues/31901 😄

injae-kim avatar Jan 15 '24 14:01 injae-kim