spring-framework icon indicating copy to clipboard operation
spring-framework copied to clipboard

Improve support and documentation for the "default" bean definition profile name

Open sbrannen opened this issue 3 years ago • 3 comments

The default profile name is a protected constant: AbstractEnvironment.RESERVED_DEFAULT_PROFILE_NAME ("default").

It is not documented in a public user-facing manner.

For example, it is not documented in @Profile and potentially in other pertinent locations.

We should improve that.

sbrannen avatar Sep 04 '22 19:09 sbrannen

To me, the concern is not just documentation. It is also the ability to use this variable or to get the name of the default profile. For example, to define a certain bean for default profile. Agree? If yes would this change also qualify as an enhancement?

bhuvanaindukuri avatar Sep 27 '22 12:09 bhuvanaindukuri

Hi @sbrannen I am new to open source and want to contribute. Can I try with the documentation change ?

1997sanket avatar Oct 18 '22 20:10 1997sanket

Hi @1997sanket,

Thanks for the offer.

However, since we are considering more than a documentation change, we've yet to decide on the exact scope of this issue. In light of that, one of the core committers will likely take care of this issue.

Regards,

Sam

sbrannen avatar Oct 20 '22 12:10 sbrannen