spring-framework icon indicating copy to clipboard operation
spring-framework copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Optimize SpEL and property placeholder support for @Async qualifiers

Open dawn9117 opened this issue 3 years ago • 4 comments
trafficstars

optimize spel in AsyncExecutionAspectSupport

dawn9117 avatar May 31 '22 23:05 dawn9117

spel is already supported.

quaff avatar Jun 01 '22 01:06 quaff

spel is already supported.

Okay, but use cases like @Async("${executor.name:}") don't work when executor.name is not configured.

Additionally EmbeddedValueResolver can be reused.

dawn9117 avatar Jun 01 '22 01:06 dawn9117

Related Issues

  • #27818

sbrannen avatar Jun 01 '22 14:06 sbrannen

Please make the requested change and introduce a test that fails before this PR and passes after this PR.

I've already added it. Please review, thanks.

dawn9117 avatar Jun 04 '22 02:06 dawn9117

I've already added it. Please review, thanks.

Thanks for making the requested changes. I'll see about getting it merged in.

sbrannen avatar Oct 05 '22 14:10 sbrannen

This has been merged into main.

Thanks 👍

sbrannen avatar Oct 07 '22 14:10 sbrannen