spring-framework icon indicating copy to clipboard operation
spring-framework copied to clipboard
verified publisher icon spring-projects

Treat MariaDB as an independent database type

Open ben-enfuse-io opened this issue 3 years ago • 1 comments

…b.com/spring-projects/spring-framework/issues/28305

In this commit we added MariaDB as an independent database type as per #28305

Thanks for taking time to look at it!

ben-enfuse-io avatar Apr 18 '22 17:04 ben-enfuse-io

This looks like an oversight of #25811 - what do you think @jhoeller

snicoll avatar Jul 29 '22 15:07 snicoll

@ben-enfuse-io thank you for making your first contribution to Spring Framework.

snicoll avatar Aug 23 '22 05:08 snicoll

Shouldn't Spring Framework provide a dedicated DataFieldMaxValueIncrementer for MariaDB as well? I think treating MariaDB as an independent database should not be limited to the change in this PR.

For example, we have the same request in Spring Batch (see https://github.com/spring-projects/spring-batch/issues/3891), where we use a DataFieldMaxValueIncrementer to increment the IDs of the Batch domain model entities, and it feels odd to use the MySQL incrementer with MariaDB. Do you agree?

fmbenhassine avatar Oct 12 '22 07:10 fmbenhassine

@fmbenhassine please create a separate issue where we can have that discussion.

snicoll avatar Oct 12 '22 07:10 snicoll