spring-data-relational icon indicating copy to clipboard operation
spring-data-relational copied to clipboard

Support to access SqlGenerator [DATAJDBC-385]

Open spring-projects-issues opened this issue 5 years ago • 3 comments

MyeongHyeonLee opened DATAJDBC-385 and commented

The access scope of the SqlGenerator is package-public and can not be used.

I need to implement the DataAccessStrategy to support RDBMS vendors not supported by spring-data-jdbc.

I would like to reuse DefaultDataAccessStrategy and SqlGenerator.

Are you planning to change the access scope of the SqlGenerator to public?


Reference URL: https://github.com/spring-projects/spring-data-jdbc/blob/1.1.0.M4/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlGenerator.java

spring-projects-issues avatar Jun 13 '19 03:06 spring-projects-issues

Jens Schauder commented

Right now I want to keep it package private. The reason is that I see quite some changes coming for the SqlGenerator and not having to worry about backward compatibility makes things a lot easier.

So for now you are best off by copying the class or using reflection or similar.

I'll leave this issue open since at a later time making it public might be a valid option.

spring-projects-issues avatar Jun 13 '19 05:06 spring-projects-issues

+1

taeyeon-Kim avatar Jun 30 '22 07:06 taeyeon-Kim

After looking at this again: the better extension point would be Dialect. A request to add features to Dialect has probably way higher chance to actually happen.

schauder avatar Jun 30 '22 07:06 schauder