spring-data-relational icon indicating copy to clipboard operation
spring-data-relational copied to clipboard
verified publisher icon spring-projects

Supported nested conversions for AggregateReference.

Open schauder opened this issue 7 months ago • 2 comments

Restructured reading conversion process into:

  • converting technology base types (JDBC Arrays).
  • standard and custom conversions.
  • module specific conversions (AggregateReference).

Closes https://github.com/spring-projects/spring-data-relational/issues/1828

schauder avatar May 23 '25 10:05 schauder

I left a few comments. I assumed this PR would had addressed the issue of late converter registration so that we can remove AggregateReferenceConverters by considering AggregateReference in writeValue (and readValue). We should revisit those converters for having a cleaner approach and to not distribute conversion of AggregateReference to components outside of MappingRelationalConverter/MappingJdbcConverter.

I was able to simply remove AggregateReferenceConverters. They weren't used anymore.

schauder avatar May 27 '25 12:05 schauder

Oops.

schauder avatar May 27 '25 12:05 schauder

Ready for another round of review.

schauder avatar Jul 03 '25 13:07 schauder

That's merged and polished now. For the time being, I suggest keeping that change for 4.0 only and if it proves to not create downstream issues, we can consider it for backporting.

mp911de avatar Jul 16 '25 13:07 mp911de