spring-data-relational icon indicating copy to clipboard operation
spring-data-relational copied to clipboard

Add `jdbcAggregateOperationsRef` to `@EnableJdbcRepositories`

Open kota65535 opened this issue 2 years ago • 7 comments

fix: #544, #687, #994

This PR adds jdbcAggregateOperationsRef to @EnableJdbcRepositories that enables to specify JdbcAggregateOperations bean name to be used for creating repositories, which significantly simplifies the configuration for multiple repositories. I've also created a sample project for testing this feature. Multiple repositories with different dialects can be configured using two configurations (Db1Config.java, Db2Config.java). As you can see, creating the JdbcAggregateOperations bean is still a bit messy. It may be better to have some factory class for creating them.

  • [x] You have read the Spring Data contribution guidelines.
  • [x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [x] You submit test cases (unit or integration tests) that back your changes.
  • [x] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

kota65535 avatar Dec 24 '23 20:12 kota65535

Hi @mp911de @schauder, could you please take a look?

kota65535 avatar Jan 11 '24 08:01 kota65535

@Mikhail2048 Thanks for your review. I've fixed the points you mentined, please check it.

kota65535 avatar Feb 06 '24 10:02 kota65535

@mp911de @schauder Could this PR be included to 3.3 M2? Thank you!

kota65535 avatar Mar 01 '24 00:03 kota65535

@mp911de @schauder @Mikhail2048 Could you please review when you have time?

kota65535 avatar Mar 19 '24 00:03 kota65535