spring-data-redis icon indicating copy to clipboard operation
spring-data-redis copied to clipboard
verified publisher icon spring-projects

Simplify LettuceConnectionUnitTests

Open onobc opened this issue 2 weeks ago • 3 comments

Currently the LettuceConnectionUnitTests are testing all variations of the conversion from options to Lettuce params.

However, most of these conversions are handles in the Lettuce StreamConverters class. Ideally these variants would be unit tested well in a StreamConvertersUnitTests. This is the pattern that Jedis uses.

This would allow the LettuceConnectionUnitTests to be simplified and just verify that the options were passed in during the API call rather than test all conversion variants.

  • [ ] Introduce a Lettuce StreamConvertersUnitTests (can use Jedis counterpart for inspiration)
  • [ ] Simplify the LettuceConnectionUnitTests in favor of the above
  • [ ] Be sure to include all APIs that handle their options -> params conversions via StreamConverters (e.g. xadd, xtrim, etc...)

onobc avatar Dec 08 '25 18:12 onobc

Hi, @onobc! I'm interested in working on this issue. If it's not currently assigned, could I please take this on?

Jimin730 avatar Dec 15 '25 07:12 Jimin730

👋🏻 @Jimin730 , sure thing. Let me know if you need any clarifications.

Thanks, Chris

onobc avatar Dec 15 '25 19:12 onobc

Thanks! I'll start working on this shortly.

Jimin730 avatar Dec 16 '25 02:12 Jimin730