spring-data-redis
spring-data-redis copied to clipboard
spring-projects
Add `IDLE` argument to `XPENDING` command
Description
Hello, I'm happy to be here. This is my first time contributing to the Spring Framework.
This pull request resolves #2046 and implements the actual execution.
Below is what I have planned in my mind and my progress so far.
To do
Property test
- [x]
XPendingOptions(at RedisStreamCommandsUnitTests) - [x]
PendingRecordsCommand(at ReactiveStreamCommandsUnitTests)
Imperative pending command test
// RedisStreamCommands.java
PendingMessages xPending(byte[] key, String groupName, XPendingOptions options);
- [x]
JedisClusterStreamCommands(at AbstractConnectionIntegrationTests) - [x]
JedisStreamCommands(at AbstractConnectionIntegrationTests) - [x]
LettuceStreamCommands(at AbstractConnectionIntegrationTests)
Reactive pending command test
// ReactiveStreamCommands.java
Flux<CommandResponse<PendingRecordsCommand, PendingMessages>> xPending(Publisher<PendingRecordsCommand> commands);
- [x]
LettuceReactiveStreamCommands(at LettuceReactiveStreamCommandsIntegrationTests)
Miscellaneous
- [ ] Match the parameter order to be the same as in the Redis CLI.
- [x] Squash to just one commit
- [x] Double check contribution guideline like commit message format, DCO, etc.
Contribution guides
- [x] You have read the Spring Data contribution guidelines.
- [x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
Hi @christophstrobl, Hope you're doing well! Just wanted to check in on the PR I sent a while back. I'm happy to revise it if needed.
Thank you for your contribution @whatasame! Merged to main development line.