spring-data-redis icon indicating copy to clipboard operation
spring-data-redis copied to clipboard

Can't Handle GCP Memory Store Redis having extra characters in ClusterNode Entry

Open lightistor opened this issue 11 months ago • 3 comments

There is an extra character in Cluster Node Line Entry for Google Cloud Platform Memory Store Redis and when using the Jedis with spring-data-redis, the following exception is thrown:

Connector. Sample entries causing ClusterNode information does not define host and port:

sample entry:

3765733728631672640db35fd2f04743c03119c6 10.180.0.33:11003@16379, master - 0 1708041426947 2 connected 5462-10922

lightistor avatar Mar 04 '24 03:03 lightistor

Addressed with pull-request: https://github.com/spring-projects/spring-data-redis/pull/2846

lightistor avatar Mar 04 '24 03:03 lightistor

The comma is introduced by https://github.com/redis/redis/pull/9564 (cluster hostname support). Another segment uses aux fields (https://github.com/redis/redis/pull/10536).

mp911de avatar Mar 04 '24 08:03 mp911de

The comma is introduced by redis/redis#9564 (cluster hostname support). Another segment uses aux fields (redis/redis#10536).

I have updated the pull-request with the fix to typo and added the unit test for the case (updated both class headers with author name per requirements checklist). Can you review?

lightistor avatar Mar 04 '24 12:03 lightistor