spring-data-redis icon indicating copy to clipboard operation
spring-data-redis copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Update Converters.java

Open lightistor opened this issue 1 year ago • 6 comments

Clean extra character in Cluster Node Line Entry for Google Cloud Platform Memory Store Redis when using the Jedis Connector. Sample entries causing ClusterNode information does not define host and port: 3765733728631672640db35fd2f04743c03119c6 10.180.0.33:11003@16379, master - 0 1708041426947 2 connected 5462-10922

  • [x] You have read the Spring Data contribution guidelines.
  • [x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [x] You submit test cases (unit or integration tests) that back your changes.
  • [x] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

lightistor avatar Feb 15 '24 23:02 lightistor

@lightistor Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Feb 15 '24 23:02 pivotal-cla

@lightistor Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Feb 16 '24 00:02 pivotal-cla

@christophstrobl and @mp911de this is a fix to handle the format of the Cluster Node Line Entry for Google Cloud Platform Memory Store Redis that we are integrating our services with. is it possible for me get assistance in merging this as a nightly build so that it is publicly available as opposed to us having have to host this fork internally?

lightistor avatar Feb 16 '24 09:02 lightistor

Please provide a test case so that we document what isn't working right now for you and what should work. Also, source..replace is a syntax error introduced with this PR.

mp911de avatar Mar 04 '24 08:03 mp911de

Please provide a test case so that we document what isn't working right now for you and what should work. Also, source..replace is a syntax error introduced with this PR.

fixed the typo, added the unit test (toSetOfRedisClusterNodesShouldConvertNodesWithEmptyHumanReadableClusterNameInGcpMemoryStoreCorrectly, uses the entry format CLUSTER_NODE_ENTRY_WITH_EMPTY_HUMAN_READABLE_CLUSTER_NAME_IN_GCP_MEMORY_STORE) and added myself to the authors in the header (per the checklist)

lightistor avatar Mar 04 '24 10:03 lightistor

So, what is the possibility of it getting merged one day @mp911de ?

lightistor avatar Mar 08 '24 02:03 lightistor