spring-data-redis icon indicating copy to clipboard operation
spring-data-redis copied to clipboard

Add approximate trimming to reactive stream extensions

Open Quantum64 opened this issue 3 years ago • 2 comments

This change adds the approximateTrimming option to the reactive stream operations coroutines extension. I do not think this change warrants an additional test case since this function is already covered, but let me know if it does.

The @JvmOverloads annotation was added to maintain compatibility with previous versions of this class. Binary compatibility is maintained, so this change is fully compatible and non-breaking. Binary compatibility was confirmed using the javap command.

Before

public static final <K, HK, HV> java.lang.Object trimAndAwait(org.springframework.data.redis.core.ReactiveStreamOperations<K, HK, HV>, K, long, kotlin.coroutines.Continuation<? super java.lang.Long>);

After

public static final <K, HK, HV> java.lang.Object trimAndAwait(org.springframework.data.redis.core.ReactiveStreamOperations<K, HK, HV>, K, long, boolean, kotlin.coroutines.Continuation<? super java.lang.Long>);
public static java.lang.Object trimAndAwait$default(org.springframework.data.redis.core.ReactiveStreamOperations, java.lang.Object, long, boolean, kotlin.coroutines.Continuation, int, java.lang.Object);
public static final <K, HK, HV> java.lang.Object trimAndAwait(org.springframework.data.redis.core.ReactiveStreamOperations<K, HK, HV>, K, long, kotlin.coroutines.Continuation<? super java.lang.Long>);

Quantum64 avatar Jan 07 '22 07:01 Quantum64

@Quantum64 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Jan 07 '22 07:01 pivotal-cla

@Quantum64 Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Jan 07 '22 07:01 pivotal-cla

Thank you for your contribution. That's merged, polished, and backported now.

mp911de avatar Sep 21 '22 13:09 mp911de