spring-data-mongodb icon indicating copy to clipboard operation
spring-data-mongodb copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Fix missing query options when calling MongoTemplate#findAndModify

Open sriram-1729 opened this issue 1 year ago • 2 comments

Forward maxTimeMsec from Query to FindOneAndUpdateOptions.

Closes #4776

sriram-1729 avatar Sep 05 '24 17:09 sriram-1729

Thank you @sriram-1729 for taking the time to create this PR. The signature change of doFindAndModify may cause trouble for people upgrading. I'm not sure if there's away around this change. Need to have a closer look.

christophstrobl avatar Sep 06 '24 05:09 christophstrobl

Hello @christophstrobl! In case the method signature change is allowed, should I keep the changes minimal, or can I make further modifications to remove redundant arguments?

sriram-1729 avatar Sep 19 '24 06:09 sriram-1729