spring-data-mongodb icon indicating copy to clipboard operation
spring-data-mongodb copied to clipboard

add: equals method to aggregation and aggregation ops

Open therealansh opened this issue 1 year ago β€’ 4 comments

Closes #4692 , Sorry for being the impatient one 😬 but would love to contribute.

  • [x] Aggregation
  • [x] AggregationPipeline
  • [ ] AggregationOperations:
    • [x] AddFieldsOperation
    • [x] BasicAggregation
    • [x] BucketAutoOperation

  • [x] You have read the Spring Data contribution guidelines.
  • [x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [ ] You submit test cases (unit or integration tests) that back your changes.
  • [ ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

therealansh avatar Apr 17 '24 07:04 therealansh

@therealansh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Apr 17 '24 07:04 pivotal-cla

@therealansh Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Apr 17 '24 07:04 pivotal-cla

Sorry for being the impatient one 😬 but would love to contribute.

Thanks a lot for your contribution, we're happy to welcome contributions, also from impatient ones 🀩

While at it, we have a couple more AggregationOperations. Care to extend the pull request by adding equals/hashCode methods to the remaining types as well? That would greatly improve the duration until we can merge your pull request.

mp911de avatar Apr 23 '24 07:04 mp911de

@mp911de was on it already, thats why added a checklist to the PR summary, will extend this PR to cover those as well thanks πŸ™ŒπŸ½

therealansh avatar Apr 23 '24 19:04 therealansh