spring-data-mongodb icon indicating copy to clipboard operation
spring-data-mongodb copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Make ChangeStreamOptionsBuilder support startAtOperationTime

Open tudormarc opened this issue 2 years ago • 1 comments

Make ChangeStreamOptionsBuilder support startAtOperationTime

Closes #3460

  • [x] You have read the Spring Data contribution guidelines.
  • [x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [x] You submit test cases (unit or integration tests) that back your changes.
  • [x] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

tudormarc avatar May 31 '22 13:05 tudormarc

Thanks for the PR!

christophstrobl avatar Jun 13 '22 07:06 christophstrobl

After a closer look at the PR it seems the newly introduced methods/properties are never propagated to the driver. As @mp911de already mentioned, it is already possible to set startAtOperationTime via resumeAt. This is my bad, sorry - I should have taken a closer look upfront. Nevertheless your PR helped us identify a glitch (#4167) in the existing reactive implementation which does apply the resume token for startAfter incorrectly to resumeAfter

christophstrobl avatar Sep 16 '22 09:09 christophstrobl

Superseded by #4167

mp911de avatar Sep 16 '22 12:09 mp911de