spring-data-jpa
spring-data-jpa copied to clipboard
DATAJPA-1277 - Additional extension point for simple jpa repository
- made CriteriaQuery building for methods: "getQuery" and "getCountQuery" more extensible (protected methods extracted)
- allows for generic query modification while using the core SimpleJpaRepository functionality
- can reuse more logic from SimpleJpaRepository on extensions/derivations of this class
- feedback welcome
- [x] You have read the Spring Data contribution guidelines.
- [x] There is a ticket in the bug tracker for the project in our JIRA.
- [x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- [ ] You submit test cases (unit or integration tests) that back your changes. Well - this was just a refactoring - not entirely sure what test cases I was supposed to add (suggestions are very welcome here)
- [x] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
@androidbod Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Not sure if the minor refactoring I did within this feature branch requires me to sign the contributor license agreement. after all, i just rearranged a bit of existing code :-)
@androidbod Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
I frankly don't see the value this alteration makes to Spring Data JPA.
That fine - I don't think this functionality is required anymore.