spring-data-examples
spring-data-examples copied to clipboard
Add elasticsearch repository test
- [x] You have read the Spring Data contribution guidelines.
- [x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
- Add elasticsearch repository test cases;
- Fix: use
LocalDaterather thanStringtype to match the annotation@Field(type = Date). The formerStringtype is a misuse of date type and will cause the following warn:WARN org.springframework.data.elasticsearch.core.mapping.SimpleElasticsearchPersistentProperty - Unsupported type 'class java.lang.String' for date property 'date'. - Use singleton containers when testing using testcontainers;
@sothawo what do you think?
I will have a look, but cannot do this before the next weekend
Closing as this pull request wasn't updated in time. If you would like us to look at this issue, please provide additional information and we will re-open the issue.
Sorry for the late response. The code has been modified according to the review suggestions.