spring-data-examples icon indicating copy to clipboard operation
spring-data-examples copied to clipboard

Move blocking random key generation to executor thread

Open Arooba-git opened this issue 2 years ago • 1 comments

Thank you for the effort for this handy project!

This is a minor fix pertaining to a blocking call in KeyCommandsTests class as detected by BlockHound: eg-blocking

Of course the method is just used in the test cases but since this is the official examples repository, I think the fix could set a good example for how we should try to avoid blocking calls in reactive apps wherever possible, to keep the pipeline reactive end to end. :)

We re-ran the test cases and also evaluated the performance (in terms of latency) before and after the fix

Parking duration of main thread before fix eg-latency-after

After eg-latency-before

Arooba-git avatar Jul 22 '23 19:07 Arooba-git