spring-data-couchbase icon indicating copy to clipboard operation
spring-data-couchbase copied to clipboard

Refactor - Reorder modifier as per java spec

Open prasanth08 opened this issue 3 years ago • 4 comments

  • [x] You have read the Spring Data contribution guidelines.
  • [ ] There is a ticket in the bug tracker for the project in our JIRA.
  • [ ] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [ ] You submit test cases (unit or integration tests) that back your changes.
  • [ ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

prasanth08 avatar Sep 10 '22 06:09 prasanth08

@prasanth08 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Sep 10 '22 06:09 pivotal-cla

@prasanth08 Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Sep 10 '22 06:09 pivotal-cla

No specific ordering of class modifiers is required.

https://docs.oracle.com/javase/specs/jls/se11/html/jls-8.html#jls-8.1.1 "If two or more (distinct) class modifiers appear in a class declaration, then it is customary, though not required, that they appear in the order consistent with that shown above in the production for ClassModifier."

mikereiche avatar Sep 12 '22 21:09 mikereiche

I agree it's not required, There is a new Java Style Guidelines initiative in place for projects in the OpenJDK community. http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-modifiers Again it's not required but customary.

prasanth08 avatar Sep 13 '22 02:09 prasanth08