spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

Group Kafka properties that configure the back-off policy

Open wilkinsona opened this issue 1 year ago • 2 comments

We have 4 properties that are used to configure the back-off policy:

  • spring.kafka.retry.topic.delay
  • spring.kafka.retry.topic.max-delay
  • spring.kafka.retry.topic.multiplier
  • spring.kafka.retry.topic.random-back-off

There are two other properties at the same level that are not related to the back-off policy:

  • spring.kafka.retry.topic.attempts
  • spring.kafka.retry.topic.enabled

We should group the four back-off related properties to make their purpose clear:

  • spring.kafka.retry.topic.backoff.delay
  • spring.kafka.retry.topic.backoff.max-delay
  • spring.kafka.retry.topic.backoff.multiplier
  • spring.kafka.retry.topic.backoff.random

wilkinsona avatar Jun 04 '24 17:06 wilkinsona

Hello, I would like to work on this issue if you believe it to be a good first contribution for someone to work on. I've taken an initial look at the code and I believe I can do it.

travisriegler avatar Jun 23 '24 21:06 travisriegler

Thanks, @travisriegler, it's all yours.

Just in case you're not already aware, when introducing the new properties, the existing properties should be kept in a deprecated form. You can deprecate them by adding @DeprecatedConfigurationProperty to each deprecated property's getter method.

wilkinsona avatar Jun 24 '24 06:06 wilkinsona

Closing in favor of #41335

scottfrederick avatar Jul 08 '24 16:07 scottfrederick