Create an alternative to InvalidConfigurationPropertyValueException for cases where there isn't a single solution

[philwebb]

See https://github.com/spring-projects/spring-boot/issues/33261#issuecomment-2075055929

We'd like a new exception type and failure analyzer for the example listed in the above comment.

[stevbark]

Hello @philwebb my name is Stephen, I am new to this project.

Does this story still need to be done? If so I am interested in picking this story up.

Is the best place to ask questions related to working on this project in stackoverflow.com tagged with spring-boot or the Gitter community mentioned in the readme?

Thanks

[philwebb]

Hi @stevbark,

This issue is still open and needs to be handled, however, we haven't yet branched the code so we won't be able to merge anything until that happens.

Questions relating to a specific issue can be asked on the the issue itself, for general help contributing Gitter is probably best. Questions on stackoverflow.com should be for general problems, I think questions specifically about contributing are probably going to be down-voted on stackoverflow.com.

We also have this wiki page which should help you get started with the basics of working with the code.

Thanks for getting involved!

[stevbark]

Thanks for the warm welcome @philwebb,

When you say we havent branched the code, does this mean I create a new branch from the main branch that I work on? Or is this branched code something else entirely that I need to wait for?

Thanks

[wilkinsona]

@stevbark There may be a delay in merging the changes until we've created the 3.3.x branch and main is building 3.4.0 snapshots but there's no need for you to wait. Please submit your changes based off the main branch and we'll take things from there.

[stevbark]

Hello @philwebb, I got a notification last week saying that Lee Anne was "going to open PR within [last] weekend if nobody handles this issue." However, I dont see that message here. Should I continue to work on this story or has it been completed? Thanks

[wilkinsona]

Please carry on, @stevbark, we haven't received a contribution from anyone else. I'll assign the issue to you so that the ownership is clearer to others.

[stevbark]

Thanks!

I am also having an issue where the checkFormatMain function keeps giving me Formatting violations and asking me to run 'format'. I am on intellij and ran the reformat code but I still am getting this issue. Do I need to update format parameters? Im unsure where I can find out more about this issue.

[wilkinsona]

Running ./gradlew format on the command line should be all that's necessary. If you want to format the code in IntelliJ then you should install the Spring Java Format plugin so that it formats the code correctly.

[stevbark]

Thanks! That solved the issue. I am also having a problem with the spring boot gradle plugin test giving me an "UnexpectedBuildFailure". I am getting errors from the NativeImagePluginActionIntegrationTests for Gradle 7.6.4 saying the tests failed the task for 'collectReachabilityMetadata'. I want to look into the issue but I am unsure how to fix this one. I assumed it was caused because I update some code to use the new exception but some of test cases are probably still looking for the old exception. Is there somewhere I can find out more? I can share the test reports if needed.

[wilkinsona]

I assumed it was caused because I update some code to use the new exception

Changes in the Gradle plugin are out of scope for this issue so please don't worry about that. We're just interested in the new exception and accompanying failure analyzer at this point. Both of those should be added to the spring-boot module so please feel free to focus your efforts there. You can use ./gradlew spring-boot-project:spring-boot to build just that module.

[stevbark]

Thanks! My code passed the tests.

I am curious to the next steps. Currently I cannot push to the spring boot repo even on a custom branch. Do I need access or do I need a code review first? I am happy with either or if there is a different way you want to proceed.

[wilkinsona]

You should create a fork of this repository and then create a pull request from your fork.

[stevbark]

I created a fork and made a pull request. https://github.com/spring-projects/spring-boot/pull/41597 let me know if you want any changes. Thanks